packages/server/src/observable/behaviorSubject.test.ts (1)

1-1: Move this test to packages/observable/ to co-locate it with its source.

The behaviorSubject.ts source was extracted to packages/observable/src/, but this test remains in packages/server/src/observable/. The test has no server-specific dependencies and tests only observable functionality—it should be placed alongside its source in the observable package for clarity of ownership and easier maintenance.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/server/src/observable/behaviorSubject.test.ts` at line 1, The test
file behaviorSubject.test.ts lives outside the observable package; move
behaviorSubject.test.ts into the packages/observable test folder so it’s
co-located with the source that exports behaviorSubject, update any import paths
if they become relative (the import of behaviorSubject should still reference
the module that exports it), and ensure the observable package test
runner/config (jest/tsconfig or workspace test globs) includes the new file and
no longer expects it under packages/server so CI still picks it up.

packages/observable/src/index.ts (1)

1-7: Separate type re-exports from value re-exports in both mixed export {} blocks.

Two export blocks inline type alongside values — this is the export-side equivalent of the "Separate type imports from value imports" guideline.

♻️ Proposed fix

-export {
-  isObservable,
-  observable,
-  observableToAsyncIterable,
-  observableToPromise,
-  type inferObservableValue,
-} from './observable';
+export {
+  isObservable,
+  observable,
+  observableToAsyncIterable,
+  observableToPromise,
+} from './observable';
+export type { inferObservableValue } from './observable';

-export {
-  behaviorSubject,
-  type BehaviorSubject,
-  type ReadonlyBehaviorSubject,
-} from './behaviorSubject';
+export { behaviorSubject } from './behaviorSubject';
+export type { BehaviorSubject, ReadonlyBehaviorSubject } from './behaviorSubject';

As per coding guidelines: "Separate type imports from value imports" — the same convention applies to re-exports.

Also applies to: 25-29

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/observable/src/index.ts` around lines 1 - 7, The current export
block mixes value exports (isObservable, observable, observableToAsyncIterable,
observableToPromise) with a type export (inferObservableValue); split them into
separate re-exports by leaving the value exports in the existing export { ... }
from './observable' and adding a separate type-only re-export using export type
{ inferObservableValue } from './observable'; apply the same pattern wherever
other mixed export blocks occur (the other mixed block mentioned in the review)
to ensure all type re-exports are separated from value re-exports.

packages/client/src/links/wsLink/wsClient/requestManager.ts (1)

1-6: Nit: group the new @trpc/observable import with its sibling tRPC imports

@trpc/observable is currently interleaved between two @trpc/server import statements. Consider consolidating:

♻️ Suggested reorder

 import type { AnyTRPCRouter, inferRouterError } from '@trpc/server';
+import type { Observer } from '@trpc/observable';
 import type {
   TRPCClientOutgoingMessage,
   TRPCResponseMessage,
 } from '@trpc/server/unstable-core-do-not-import';
-import type { Observer } from '@trpc/observable';
 import type { TRPCClientError } from '../../../TRPCClientError';

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/client/src/links/wsLink/wsClient/requestManager.ts` around lines 1 -
6, The imports are misordered: the Observer import from '@trpc/observable' is
interleaved between two '@trpc/server' imports; consolidate related tRPC imports
by grouping AnyTRPCRouter and inferRouterError together with Observer, and keep
TRPCClientOutgoingMessage and TRPCResponseMessage (from
'@trpc/server/unstable-core-do-not-import') separate; reorder the import
statements so the '@trpc/server' and '@trpc/observable' symbols (AnyTRPCRouter,
inferRouterError, Observer) appear together to improve consistency and
readability.

packages/tests/server/smoke.test.ts (1)

8-10: Nit: @trpc/observable imports split the @trpc/server import block.

The new imports on lines 8–9 are inserted between two @trpc/server imports (lines 7 and 10), splitting what was a consecutive group. Consider moving the @trpc/observable pair adjacent to the other third-party tRPC imports or after the @trpc/server/unstable-core-do-not-import import for cleaner grouping.

♻️ Suggested ordering

 import type { inferProcedureOutput } from '@trpc/server';
 import { initTRPC } from '@trpc/server';
+import { lazy } from '@trpc/server/unstable-core-do-not-import';
 import type { Unsubscribable } from '@trpc/observable';
 import { observable } from '@trpc/observable';
-import { lazy } from '@trpc/server/unstable-core-do-not-import';
 import { z } from 'zod';

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/tests/server/smoke.test.ts` around lines 8 - 10, The three imports
Unsubscribable and observable from '@trpc/observable' and lazy from
'@trpc/server/unstable-core-do-not-import' are splitting the existing
'@trpc/server' import group; reorder imports so all `@trpc/`* imports are
contiguous (e.g., move the '@trpc/observable' import block adjacent to the other
`@trpc/server` imports or place it directly after the lazy import) to keep
third-party tRPC imports grouped together.

tsconfig.json (1)

12-12: Missing "@trpc/observable/*" wildcard path alias for consistency.

Every other @trpc/* package has both a direct alias and a wildcard alias. @trpc/observable only has the direct mapping. While no subpath imports are used today, the inconsistency could silently break subpath resolution during development if any are added.

🔧 Suggested addition

       "@trpc/observable": ["./packages/observable/src"],
+      "@trpc/observable/*": ["./packages/observable/src/*"],

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tsconfig.json` at line 12, The paths mapping for the "@trpc/observable"
package is missing a wildcard alias which makes it inconsistent with other
"@trpc/*" entries and could break subpath imports; update the tsconfig "paths"
to add the wildcard entry "@trpc/observable/*" pointing to the source directory
(e.g., map "@trpc/observable/*" to "./packages/observable/src/*") so both direct
("@trpc/observable") and wildcard ("@trpc/observable/*") resolutions work for
functions/modules that import subpaths.

packages/server/src/observable/observable.test.ts (1)

2-7: Consider moving these tests to packages/observable/ or testing through the backward-compat re-export.

This test file lives at packages/server/src/observable/observable.test.ts but now imports directly from @trpc/observable. With observable extracted into its own package, tests for the observable primitives logically belong in packages/observable/. Alternatively, if the intent is to validate the backward-compat re-export, these tests should import from @trpc/server/observable instead.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/server/src/observable/observable.test.ts` around lines 2 - 7, Tests
import observable primitives (observable, observableToAsyncIterable, share, tap)
directly from `@trpc/observable` but live in packages/server; either move this
test file into packages/observable/ to colocate tests with the extracted package
and keep the current imports, or if you intend to verify the backward-compat
re-export, change the imports to come from `@trpc/server/observable` so the test
validates the server package’s re-export; update the test module location or
imports accordingly and run the test suite to ensure imports resolve.

packages/client/src/links/wsLink/wsClient/wsClient.ts (1)

2-3: Optional: group value imports after all type imports.

The value import on line 3 is currently sandwiched between type imports (lines 1–2 and lines 4–10), violating the "Separate type imports from value imports" coding guideline.

♻️ Suggested reordering

 import type { AnyTRPCRouter } from '@trpc/server';
 import type { BehaviorSubject } from '@trpc/observable';
-import { behaviorSubject, observable } from '@trpc/observable';
 import type {
   CombinedDataTransformer,
   TRPCClientIncomingMessage,
   TRPCClientIncomingRequest,
   TRPCClientOutgoingMessage,
   TRPCResponseMessage,
 } from '@trpc/server/unstable-core-do-not-import';
+import { behaviorSubject, observable } from '@trpc/observable';
 import {
   run,
   sleep,
   transformResult,
 } from '@trpc/server/unstable-core-do-not-import';

As per coding guidelines: "Separate type imports from value imports."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/client/src/links/wsLink/wsClient/wsClient.ts` around lines 2 - 3,
The import order mixes type and value imports: move the value imports
(behaviorSubject, observable) so all type-only imports (e.g., BehaviorSubject
and any other "import type" lines) appear first and then import the values;
adjust the import statements in wsClient.ts to group "import type {
BehaviorSubject } from '@trpc/observable';" with other type imports and place
"import { behaviorSubject, observable } from '@trpc/observable';" after them to
comply with the "Separate type imports from value imports" guideline.

packages/react-query/test/useSubscription.test.tsx (1)

8-8: Move @trpc/observable and other tRPC imports before third-party imports to comply with import order guidelines.

Lines 8–10 import from @trpc/* packages but are placed after @testing-library/react (third-party, line 7). Per the coding guidelines, the order must be: test helpers → tRPC imports → third-party → relative. Consolidate all tRPC imports together before the third-party imports.

♻️ Suggested reorder

 import { getServerAndReactClient } from './__reactHelpers';
 import { IterableEventEmitter } from '@trpc/server/__tests__/iterableEventEmitter';
 import {
   ignoreErrors,
   suppressLogsUntil,
 } from '@trpc/server/__tests__/suppressLogs';
+import { observable } from '@trpc/observable';
+import type { TRPCSubscriptionResult } from '@trpc/react-query/shared';
+import { initTRPC } from '@trpc/server';
 import { fireEvent, render } from '@testing-library/react';
-import { observable } from '@trpc/observable';
-import type { TRPCSubscriptionResult } from '@trpc/react-query/shared';
-import { initTRPC } from '@trpc/server';
 import { konn } from 'konn';
 import React, { useState } from 'react';
 import { z } from 'zod';

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/react-query/test/useSubscription.test.tsx` at line 8, Move the tRPC
imports (e.g., the observable import from '@trpc/observable' and any other
'@trpc/*' imports) so they appear before third-party imports like
'@testing-library/react' to match the required import order (test helpers → tRPC
imports → third-party → relative); locate the current import statement for
observable and any other '@trpc' imports in useSubscription.test.tsx and reorder
them to be grouped together immediately after test helper imports and before
other third-party imports.

packages/observable/src/observable.test.ts (1)

1-1: Prefer node:events over stream as the source for EventEmitter.

Node.js offers the events module, which provides the EventEmitter class. The stream module is for stream-related APIs; while TypeScript's @types/node may re-export EventEmitter transitively through stream, the canonical and idiomatic import is from 'node:events' (or 'events'), as shown in the official docs.

🔧 Suggested fix

-import { EventEmitter } from 'stream';
+import { EventEmitter } from 'node:events';

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/observable/src/observable.test.ts` at line 1, Replace the
non-idiomatic import of EventEmitter from 'stream' with the canonical source
('node:events' or 'events'); locate the import statement that reads "import {
EventEmitter } from 'stream'" in observable.test.ts and change it to import
EventEmitter from 'node:events' (or 'events') so tests use the proper
EventEmitter symbol.

packages/observable/src/operators.test.ts (1)

110-111: Avoid var + eslint-disable; hoist let declarations instead.

var is used solely so subscription1/subscription2 are visible outside their respective {} blocks at lines 138–139. The inner blocks and their eslint-disable comments can be eliminated by hoisting declarations with let at the top of the test, or by dropping the artificial block scoping and using distinct local variable names:

♻️ Suggested refactor

-  {
-    const next = vi.fn();
-    const error = vi.fn();
-    const complete = vi.fn();
-
-    // eslint-disable-next-line no-var
-    var subscription1 = obs.subscribe({
-      next,
-      error,
-      complete,
-    });
-    expect(next.mock.calls).toHaveLength(1);
-    expect(complete.mock.calls).toHaveLength(0);
-    expect(error.mock.calls).toHaveLength(0);
-    expect(next.mock.calls[0]![0]).toBe(1);
-  }
-
-  {
-    // subscribe again - it's shared so should not propagate any results
-    const next = vi.fn();
-    const error = vi.fn();
-    const complete = vi.fn();
-    // eslint-disable-next-line no-var
-    var subscription2 = obs.subscribe({
-      next,
-      error,
-      complete,
-    });
-    expect(next.mock.calls).toHaveLength(0);
-    expect(complete.mock.calls).toHaveLength(0);
-    expect(error.mock.calls).toHaveLength(0);
-  }
+  const next1 = vi.fn();
+  const error1 = vi.fn();
+  const complete1 = vi.fn();
+  const subscription1 = obs.subscribe({ next: next1, error: error1, complete: complete1 });
+  expect(next1.mock.calls).toHaveLength(1);
+  expect(complete1.mock.calls).toHaveLength(0);
+  expect(error1.mock.calls).toHaveLength(0);
+  expect(next1.mock.calls[0]![0]).toBe(1);
+
+  // subscribe again - it's shared so should not propagate any results
+  const next2 = vi.fn();
+  const error2 = vi.fn();
+  const complete2 = vi.fn();
+  const subscription2 = obs.subscribe({ next: next2, error: error2, complete: complete2 });
+  expect(next2.mock.calls).toHaveLength(0);
+  expect(complete2.mock.calls).toHaveLength(0);
+  expect(error2.mock.calls).toHaveLength(0);

Also applies to: 127-128

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/observable/src/operators.test.ts` around lines 110 - 111, Replace
the use of "var" and the eslint-disable comments by hoisting subscription1 and
subscription2 as let declarations at the top of the test scope (before any inner
blocks), then remove the artificial inner blocks and their eslint-disable lines
so the calls to obs.subscribe(...) can assign into those hoisted lets; locate
the occurrences around the obs.subscribe calls referencing subscription1 and
subscription2 and change their declarations from var to let and eliminate the
block scoping.